sartre: new package

[wdconinc]

Sartre is an event generator for exclusive diffractive vector meson production and DVCS in ep and eA collisions based on the dipole model.

Notable dependencies are cuba.

TODO:

• This version is still forcing the use of the vendored package. Discussion is ongoing with the developer.

[bernhardkaindl]

@wdconinc Just notifying you that about two months passed since your last comment. You wrote:

This version is still forcing the use of the vendored package. Discussion is ongoing with the developer.

[alalazo]

What is the status of this PR?

[wdconinc]

Discussion is ongoing with the developer.

This is still not resolved (not gotten an answer). I'll wrap this up today without developer input. I'll just live with the vendored dependency or filter_file it out.

[wdconinc]

Things I would have wished the developers could address (but they haven't):

• /usr/bin/tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.lastuseddate#PS' (stuff included in tar archive that is not really supposed to be there; though maybe spack could be less loud about this too, tar --warning=no-unknown-keyword hides this),
• cuba is forcibly used as vendored dependency in a way that's hard to simply filter_file out,
• the CMakeLists.txt installs in <prefix>/sartre, which I did filter_file out.

[wdconinc]

@spackbot fix style

[spackbot-app]

Let me see if I can fix that for you!

[spackbot-app]

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/sartre/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/sartre/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 576 source files
  mypy checks were clean
==> spack style checks were clean

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

But it looks like I'm not able to push to your branch. 😭️ Did you check maintainer can edit when you opened the PR?