Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various FleCSI updates #41068

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Various FleCSI updates #41068

merged 6 commits into from
Dec 1, 2023

Conversation

rbberger
Copy link
Member

@rbberger rbberger commented Nov 14, 2023 •
edited
Loading

  • removes deprecated versions after latest Spack release
  • propagate +openmp to kokkos and Legion
  • add explicit conflict for +hdf5 when using HPX backend
  • remove doc variant for versions prior to 2.2

@spackbot-app spackbot-app bot requested a review from ktsai7 November 14, 2023 18:41
@rbberger rbberger requested review from tldahlgren and removed request for ktsai7 November 14, 2023 18:41
tldahlgren
tldahlgren previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tldahlgren tldahlgren enabled auto-merge (squash) November 15, 2023 01:03
@tldahlgren tldahlgren self-assigned this Nov 15, 2023
@tldahlgren
Copy link
Contributor

Not sure why prechecks are failing. Going to click Update branch to see if that resolves the problem.

tldahlgren and others added 2 commits November 16, 2023 11:01
@tldahlgren
Merge branch 'develop' into flecsi_updates
ca11899
@rbberger
flecsi: remove doc variant prior to @2.2
232bbab 
It wouldn't do anything meaningful and won't install the documentation.
auto-merge was automatically disabled November 17, 2023 01:16

Head branch was pushed to by a user without write access

@rbberger
Copy link
Member Author

@tldahlgren sry, pushed one more small update to the spackage.

@rbberger
Copy link
Member Author

@tldahlgren auto-merge got dismissed the other day when I pushed another small update 232bbab. This should be ready to go.

@tldahlgren tldahlgren merged commit d06a102 into spack:develop Dec 1, 2023
11 checks passed
@greenc-FNAL greenc-FNAL mentioned this pull request Dec 5, 2023
Merged
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
@rbberger @tldahlgren @RikkiButler20
Various FleCSI updates (spack#41068)
47a7b82 
* flecsi: remove deprecated versions
* flecsi: add explicit conflict for backend=hpx +hdf5
* flecsi: propagate +openmp to kokkos and legion
* flecsi: remove doc variant prior to @2.2
   It wouldn't do anything meaningful and won't install the documentation.

---------

Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
@rbberger rbberger deleted the flecsi_updates branch August 25, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tldahlgren tldahlgren tldahlgren approved these changes

Assignees

@tldahlgren tldahlgren

Labels
conflicts dependencies new-variant update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbberger @tldahlgren