verilator: Move compiler renaming to filter_compiler_wrappers #41336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tldahlgren
changed the title
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
May 21, 2024
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
May 21, 2024
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
May 21, 2024
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Jun 10, 2024
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Jun 10, 2024
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing this I was shown the better cleaner way of renaming the compilers in verilated.mk. Functionally there is no change.