Allow exago to use hiop@develop past v1.0.1 #41384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryandanehy can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
cameronrutherford
suggested changes
Dec 1, 2023
| @@ -160,7 +161,7 @@ class Exago(CMakePackage, CudaPackage, ROCmPackage): | |||
| depends_on("petsc@3.13:3.14", when="@:1.2") | |||
| depends_on("petsc@3.16", when="@1.3:1.4") | |||
| depends_on("petsc@3.18:3.19", when="@1.5") | |||
| depends_on("petsc@3.20:", when="@1.6:") | |||
| depends_on("petsc@3.19:", when="@1.6:") | |||
There was a problem hiding this comment.
@balay added this. I think it's safer just to use 3.20+ and move on from 3.19
There was a problem hiding this comment.
Hm - looking at my prior change at dbf21bf
Looks like petsc@3.20 was not in the dependency list - so my change added it in.
If petsc@3.19 works with @1.6 - its fine to add in this additional change.
ryandanehy
approved these changes
Dec 2, 2023
cameronrutherford
approved these changes
Dec 2, 2023
balay
approved these changes
Dec 2, 2023
20 tasks
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the spack package to confine previous exago releases to hiop@1.0.0 and move future versions to v1.0.1 onwards.
Adjust petsc version numbers.