-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seqfu: add v1.22.3 #47294
seqfu: add v1.22.3 #47294
Conversation
Signed-off-by: Georgia Stuart <gstuart@umass.edu>
Hi @georgiastuart! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("georgiastuart") If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame seqfu Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
@dialvarezs this looks like you! |
Great! One minor suggestion: the patch should not be necessary for versions 1.22.0 and above (see details here), so you can limit the application to the v1.20.3 version. |
Thanks @dialvarezs ! Adding that now. While I'm at it, do you want me to set you as the maintainer? |
No problem @georgiastuart ! Sure, you can put me as the maintainer, thanks! |
Signed-off-by: Georgia Stuart <gstuart@umass.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the sha256.
Adds seqfu@1.22.3