Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqfu: add v1.22.3 #47294

Merged
merged 2 commits into from
Oct 29, 2024
Merged

seqfu: add v1.22.3 #47294

merged 2 commits into from
Oct 29, 2024

Conversation

georgiastuart
Copy link
Contributor

Adds seqfu@1.22.3

Signed-off-by: Georgia Stuart <gstuart@umass.edu>
Copy link

spackbot-app bot commented Oct 29, 2024

Hi @georgiastuart! I noticed that the following package(s) don't yet have maintainers:

  • seqfu

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("georgiastuart")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame seqfu

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@georgiastuart
Copy link
Contributor Author

@dialvarezs this looks like you!

@dialvarezs
Copy link
Member

Great! One minor suggestion: the patch should not be necessary for versions 1.22.0 and above (see details here), so you can limit the application to the v1.20.3 version.

@georgiastuart
Copy link
Contributor Author

Thanks @dialvarezs ! Adding that now. While I'm at it, do you want me to set you as the maintainer?

@dialvarezs
Copy link
Member

No problem @georgiastuart ! Sure, you can put me as the maintainer, thanks!

Signed-off-by: Georgia Stuart <gstuart@umass.edu>
@dialvarezs dialvarezs requested a review from tldahlgren October 29, 2024 18:19
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the sha256.

@tldahlgren tldahlgren enabled auto-merge (squash) October 29, 2024 18:24
@tldahlgren tldahlgren self-assigned this Oct 29, 2024
@alecbcs alecbcs changed the title Add new seqfu version seqfu: add v1.22.3 Oct 29, 2024
@tldahlgren tldahlgren merged commit 3108849 into spack:develop Oct 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants