Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New urls for Kokkos and Kokkos-Kernels #47330

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

cedricchevalier19
Copy link
Contributor

Since version 4.4, Kokkos and Kokkos-Kernels have released signed tarballs.
This PR makes Spack use them instead of standard Github-generated artifacts.

Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could probably get rid of explicit URLs

@cedricchevalier19
Copy link
Contributor Author

@bernhardkaindl, can you check if it fits Spack policy and merge if so?

Copy link
Contributor

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardkaindl, can you check if it fits Spack policy and merge if so?

I'm sorry, I can't because I don't know all of them. However, as @alalazo is active now, I mention him in this comment.

Feel free to ask him or a spack maintainer that likely knows better than me.

@alalazo alalazo merged commit 2148292 into spack:develop Nov 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants