Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extrae: fix typo #47406

Merged
merged 1 commit into from
Nov 5, 2024
Merged

extrae: fix typo #47406

merged 1 commit into from
Nov 5, 2024

Conversation

giordano
Copy link
Member

@giordano giordano commented Nov 4, 2024

#47343 broke building extrae:

==> Installing extrae-4.1.2-3m2zqwnb5yl3fubfyt5jhkcq5otlqmnp
==> No binary for extrae-4.1.2-3m2zqwnb5yl3fubfyt5jhkcq5otlqmnp found: installing from source
==> Using cached archive: /home/mose/repo/spack/var/spack/cache/_source-cache/archive/ad/adbc1d3aefde7649262426d471237dc96f070b93be850a6f15280ed86fd0b952.tar.bz2
==> No patches needed for extrae
==> extrae: Executing phase: 'autoreconf'
==> extrae: Executing phase: 'configure'
==> Error: AttributeError: 'Spec' object has no attribute 'satisifes'

The 'extrae' package cannot find an attribute while trying to build from sources. This might be due to a change in Spack's package format to support multiple build-systems for a single package. You can fix this by updating the build recipe, and you can also report the issue as a bug. More information at https://spack.readthedocs.io/en/latest/packaging_guide.html#installation-procedure

/home/mose/repo/spack/var/spack/repos/builtin/packages/extrae/package.py:131, in configure_args:
        128
        129        args += (
        130            ["--with-cuda=%s" % spec["cuda"].prefix]
  >>    131            if spec.satisifes("+cuda")
        132            else ["--without-cuda"]
        133        )
        134

See build log for details:
  /tmp/mose/spack-stage/spack-stage-extrae-4.1.2-3m2zqwnb5yl3fubfyt5jhkcq5otlqmnp/spack-build-out.txt

CC: @hainest.

Copy link

spackbot-app bot commented Nov 4, 2024

Hi @giordano! I noticed that the following package(s) don't yet have maintainers:

  • extrae

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("giordano")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame extrae

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@hainest
Copy link
Contributor

hainest commented Nov 4, 2024

I am including this in #47359, but it's probably better to have it as a separate PR.

@haampie haampie enabled auto-merge (squash) November 4, 2024 15:09
@haampie haampie merged commit dcc199a into spack:develop Nov 5, 2024
15 checks passed
@giordano giordano deleted the patch-1 branch November 5, 2024 08:30
@giordano giordano restored the patch-1 branch November 26, 2024 17:39
@giordano giordano deleted the patch-1 branch November 26, 2024 17:39
fryeguy52 pushed a commit to fryeguy52/spack that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants