re-enable and autofix no-extra-semi rule

.eslintrc

@@ -2,5 +2,4 @@
 extends: '@elastic/kibana'
 rules:
   no-unused-vars: off
-  no-extra-semi: off
   quotes: off

src/cli_plugin/install/cleanup.js

@@ -19,7 +19,7 @@ export function cleanPrevious(settings, logger) {
       resolve();
     }
   });
-};
+}
 
 export function cleanArtifacts(settings) {
   // delete the working directory.
@@ -29,4 +29,4 @@ export function cleanArtifacts(settings) {
     rimraf.sync(settings.plugins[0].path);
   }
   catch (e) {} // eslint-disable-line no-empty
-};
+}

src/cli_plugin/install/download.js

@@ -42,4 +42,4 @@ export function download(settings, logger) {
   }
 
   return tryNext();
-};
+}

src/cli_plugin/install/index.js

@@ -47,4 +47,4 @@ export default function pluginInstall(program) {
   install file:///Path/to/my/x-pack.zip
   install https://path.to/my/x-pack.zip`)
   .action(processCommand);
-};
+}

src/cli_plugin/install/pack.js

@@ -134,4 +134,4 @@ export async function extract(settings, logger) {
     logger.error(err);
     throw new Error('Error extracting plugin archive');
   }
-};
+}

src/cli_plugin/install/settings.js

@@ -21,7 +21,7 @@ export function parseMilliseconds(val) {
   }
 
   return result;
-};
+}
 
 export function parse(command, options, kbnPackage) {
   const settings = {
@@ -44,4 +44,4 @@ export function parse(command, options, kbnPackage) {
   };
 
   return settings;
-};
+}

src/cli_plugin/lib/errors.js

@@ -1 +1 @@
-export class UnsupportedProtocolError extends Error {};
+export class UnsupportedProtocolError extends Error {}

src/cli_plugin/lib/logger.js

@@ -41,6 +41,6 @@ export default class Logger {
     }
     process.stderr.write(`${data}\n`);
     this.previousLineEnded = true;
-  };
+  }
 
 }

src/cli_plugin/list/index.js

@@ -27,4 +27,4 @@ export default function pluginList(program) {
     )
     .description('list installed plugins')
     .action(processCommand);
-};
+}

src/cli_plugin/list/settings.js

@@ -6,4 +6,4 @@ export function parse(command, options) {
   };
 
   return settings;
-};
+}

src/cli_plugin/remove/index.js

@@ -37,4 +37,4 @@ export default function pluginRemove(program) {
 `common examples:
   remove x-pack`)
   .action(processCommand);
-};
+}

src/cli_plugin/remove/settings.js

@@ -12,4 +12,4 @@ export function parse(command, options) {
   settings.pluginPath = resolve(settings.pluginDir, settings.plugin);
 
   return settings;
-};
+}

src/core_plugins/elasticsearch/lib/create_proxy.js

@@ -29,7 +29,7 @@ function createProxy(server, method, route, config) {
   assign(options.config, config);
 
   server.route(options);
-};
+}
 
 createProxy.createPath = function createPath(path) {
   const pre = '/elasticsearch';

src/core_plugins/elasticsearch/lib/get_basic_auth_realm.js

@@ -4,4 +4,4 @@ export default function getBasicAuthRealm(message) {
   const parts = message.match(/Basic\ realm=\\"(.*)\\"/);
   if (parts && parts.length === 2) return parts[1];
   else return null;
-};
+}

src/core_plugins/elasticsearch/lib/map_uri.js

@@ -19,4 +19,4 @@ export default function mapUri(server, prefix) {
     const customHeaders = setHeaders(filteredHeaders, config.get('elasticsearch.customHeaders'));
     done(null, url, customHeaders);
   };
-};
+}

src/core_plugins/kbn_doc_views/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/kbn_vislib_vis_types/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/area.js

@@ -71,4 +71,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/histogram.js

@@ -67,4 +67,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/line.js

@@ -77,4 +77,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/pie.js

@@ -57,4 +57,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/tile_map.js

@@ -98,4 +98,4 @@ export default function TileMapVisType(Private, getAppState, courier, config) {
       }
     ])
   });
-};
+}

src/core_plugins/kibana/public/dashboard/components/panel/lib/load_panel.js

@@ -15,4 +15,4 @@ export default function loadPanelFunction(Private) { // Inject services here
     }
 
   };
-};
+}

src/core_plugins/kibana/public/dashboard/components/panel/lib/search.js

@@ -21,4 +21,4 @@ export default function searchLoader(savedSearches, Private) { // Inject service
         };
       });
   };
-};
+}

src/core_plugins/kibana/public/dashboard/components/panel/lib/visualization.js

@@ -20,4 +20,4 @@ export default function visualizationLoader(savedVisualizations, Private) { // I
       };
     });
   };
-};
+}

src/core_plugins/kibana/public/dashboard/services/saved_dashboard_register.js

@@ -1,3 +1,3 @@
 export default function savedDashboardFn(savedDashboards) {
   return savedDashboards;
-};
+}

src/core_plugins/kibana/public/discover/saved_searches/saved_search_register.js

@@ -1,3 +1,3 @@
 export default function savedSearchObjectFn(savedSearches) {
   return savedSearches;
-};
+}

src/core_plugins/kibana/public/management/sections/indices/_date_scripts.js

@@ -23,4 +23,4 @@ export default function (indexPattern) {
   });
 
   return dateScripts;
-};
+}

src/core_plugins/kibana/public/management/sections/indices/_field_types.js

@@ -21,4 +21,4 @@ export default function GetFieldTypes() {
       count: fieldCount.scripted
     }];
   };
-};
+}

src/core_plugins/kibana/public/management/sections/indices/_refresh_kibana_index.js

@@ -4,4 +4,4 @@ export default function RefreshKibanaIndexFn(es, kbnIndex) {
       index: kbnIndex
     });
   };
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/lib/create_multi_select_model.js

@@ -14,7 +14,7 @@ export default function selectableArray(items, selectedItems) {
       selected: !_.isUndefined(selected)
     };
   });
-};
+}
 
 function cleanItem(item) {
   return _.trim(item).toUpperCase();

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/lib/keys_deep.js

@@ -18,4 +18,4 @@ export default function keysDeep(object, base) {
   }
 
   return result;
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/append/view_model.js

@@ -20,4 +20,4 @@ export class Append extends Processor {
       values: this.values || []
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/convert/view_model.js

@@ -25,4 +25,4 @@ export class Convert extends Processor {
       type: this.type || 'auto'
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/date/view_model.js

@@ -29,4 +29,4 @@ export class Date extends Processor {
       customFormat: this.customFormat || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/geoip/view_model.js

@@ -25,4 +25,4 @@ export class GeoIp extends Processor {
       databaseFields: this.databaseFields || []
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/grok/view_model.js

@@ -27,4 +27,4 @@ export class Grok extends Processor {
       pattern: this.pattern || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/gsub/view_model.js

@@ -22,4 +22,4 @@ export class Gsub extends Processor {
       replacement: this.replacement || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/join/view_model.js

@@ -21,4 +21,4 @@ export class Join extends Processor {
       separator: this.separator || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/lowercase/view_model.js

@@ -18,4 +18,4 @@ export class Lowercase extends Processor {
       sourceField: this.sourceField || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/remove/view_model.js

@@ -18,4 +18,4 @@ export class Remove extends Processor {
       sourceField: this.sourceField || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/rename/view_model.js

@@ -21,4 +21,4 @@ export class Rename extends Processor {
       targetField: this.targetField || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/set/view_model.js

@@ -20,4 +20,4 @@ export class Set extends Processor {
       value: this.value || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/split/view_model.js

@@ -21,4 +21,4 @@ export class Split extends Processor {
       separator: this.separator || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/trim/view_model.js

@@ -18,4 +18,4 @@ export class Trim extends Processor {
       sourceField: this.sourceField || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/processors/uppercase/view_model.js

@@ -18,4 +18,4 @@ export class Uppercase extends Processor {
       sourceField: this.sourceField || ''
     };
   }
-};
+}

src/core_plugins/kibana/public/visualize/saved_visualizations/saved_visualization_register.js

@@ -1,3 +1,3 @@
 export default function savedVisualizationFn(savedVisualizations) {
   return savedVisualizations;
-};
+}

src/core_plugins/kibana/server/lib/process_es_ingest_processors_response.js

@@ -13,4 +13,4 @@ export default function processESIngestProcessorsResponse(response) {
     .value();
 
   return results;
-};
+}

src/core_plugins/kibana/server/lib/process_es_ingest_simulate_response.js

@@ -21,4 +21,4 @@ export default function processESIngestSimulateResponse(resp) {
   });
 
   return results;
-};
+}

src/core_plugins/kibana/server/routes/api/ingest/register_delete.js

@@ -34,4 +34,4 @@ export function registerDelete(server) {
       );
     }
   });
-};
+}

src/core_plugins/kibana/server/routes/api/ingest/register_post.js

@@ -143,4 +143,4 @@ export function registerPost(server) {
       );
     }
   });
-};
+}

src/core_plugins/kibana/server/routes/api/ingest/register_processors.js

@@ -21,4 +21,4 @@ export function registerProcessors(server) {
       });
     }
   });
-};
+}

src/core_plugins/kibana/server/routes/api/ingest/register_simulate.js

@@ -34,4 +34,4 @@ export function registerSimulate(server) {
       });
     }
   });
-};
+}

src/core_plugins/markdown_vis/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/metric_vis/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/spy_modes/index.js

@@ -7,4 +7,4 @@ export default function (kibana) {
       ]
     }
   });
-};
+}

src/core_plugins/status_page/index.js

@@ -9,4 +9,4 @@ export default function (kibana) {
       }
     }
   });
-};
+}

src/core_plugins/table_vis/index.js

@@ -8,4 +8,4 @@ export default function (kibana) {
     }
   });
 
-};
+}

src/fixtures/agg_resp/geohash_grid.js

@@ -78,4 +78,4 @@ export default function GeoHashGridAggResponseFixture() {
       }
     }
   };
-};
+}

src/fixtures/fake_row.js

@@ -17,4 +17,4 @@ export default function (id, mapping) {
     $$_partialFormatted: fakeVals('formatted'),
     $$_flattened: fakeVals('_flattened')
   };
-};
+}

src/fixtures/hits.js

@@ -19,4 +19,4 @@ export default function fitsFixture() {
       _index: 'test-index'
     });
   });
-};
+}

src/fixtures/mock_courier.js

@@ -13,4 +13,4 @@ export default function (Private, Promise) {
   };
 
   return courier;
-};
+}

src/fixtures/stubbed_logstash_index_pattern.js

@@ -22,4 +22,4 @@ export default function stubbedLogstashIndexPatternService(Private) {
 
   return indexPattern;
 
-};
+}