Add inject_context and current_context #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| @@ -622,8 +646,10 @@ defmodule Spandex.Test.SpandexTest do | |||
| |> Plug.Test.conn("/") | |||
| |> Plug.Conn.put_req_header("x-test-trace-id", "1234") | |||
| |> Plug.Conn.put_req_header("x-test-parent-id", "5678") | |||
| |> Plug.Conn.put_req_header("x-test-sampling-priority", "10") | |||
There was a problem hiding this comment.
Nested modules could be aliased at the top of the invoking module.
| opts = @base_opts ++ @span_opts | ||
| assert {:ok, %Trace{id: trace_id}} = Spandex.start_trace("root_span", opts) | ||
| assert {:ok, %Span{id: span_id}} = Spandex.start_span("span_name", @base_opts) | ||
| assert {:ok, %SpanContext{trace_id: ^trace_id, parent_id: ^span_id}} = Spandex.current_context(@base_opts) |
There was a problem hiding this comment.
Line is too long (max is 100, was 112).
lib/spandex.ex
Outdated
| def current_context(opts) do | ||
| strategy = opts[:strategy] | ||
| case strategy.get_trace(opts[:trace_key]) do | ||
| {:ok, %Trace{id: trace_id, priority: priority, baggage: baggage, stack: [%Span{id: span_id} | _]}} -> |
There was a problem hiding this comment.
Line is too long (max is 100, was 107).
lib/spandex.ex
Outdated
| strategy = opts[:strategy] | ||
| case strategy.get_trace(opts[:trace_key]) do | ||
| {:ok, %Trace{id: trace_id, priority: priority, baggage: baggage, stack: [%Span{id: span_id} | _]}} -> | ||
| {:ok, %SpanContext{trace_id: trace_id, priority: priority, baggage: baggage, parent_id: span_id}} |
There was a problem hiding this comment.
Line is too long (max is 100, was 105).
| @@ -6,6 +6,7 @@ defmodule Spandex.Adapter do | |||
| @callback distributed_context(Plug.Conn.t(), Keyword.t()) :: | |||
| {:ok, Spandex.SpanContext.t()} | |||
| | {:error, atom()} | |||
| @callback inject_context(Spandex.headers(), Spandex.SpanContext.t(), Keyword.t()) :: Spandex.headers() | |||
There was a problem hiding this comment.
Line is too long (max is 100, was 104).
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/spandex-project/spandex/pulls/78. |
GregMefford
force-pushed
the
inject_context
branch
from
2805e52 to
bb1cf01
Compare
|
|
||
| case strategy.get_trace(opts[:trace_key]) do | ||
| {:ok, %Trace{id: trace_id, priority: priority, baggage: baggage, stack: [%Span{id: span_id} | _]}} -> | ||
| {:ok, %SpanContext{trace_id: trace_id, priority: priority, baggage: baggage, parent_id: span_id}} |
There was a problem hiding this comment.
Line is too long (max is 100, was 105).
Pull Request Test Coverage Report for Build 348
💛 - Coveralls |
zachdaniel
approved these changes
Sep 14, 2018
|
Ok, I think this PR is ready to merge. If you think these last commits are good, I can hit the button and then work on a release-prep PR for 2.3.0 so that I can bump the version requirement in |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds APIs for
current_context(to allow people to get access to aSpanContextbased on the current span context) andinject_contextto simplify adding distributed tracing headers to HTTP calls.This somewhat-unfortunately also required an update to the
Adapterbehaviour, so I've also got a PR toSpandexDatadogqueued up (spandex-project/spandex_datadog#6).