Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for app analytics #23

Merged
merged 1 commit into from
Apr 23, 2020
Merged

feat: add support for app analytics #23

merged 1 commit into from
Apr 23, 2020

Conversation

baquiax
Copy link
Contributor

@baquiax baquiax commented Apr 23, 2020

One of the most useful features of DataDog is the App Analytcs
https://docs.datadoghq.com/tracing/app_analytics. It allows you
track the 100% of your traces to have a full visilibity about
what's going on.

We add this new feature to support it. You only need to add in
the tags the key-value: :analytics_event: true.

One of the most useful features of DataDog is the App Analytcs
https://docs.datadoghq.com/tracing/app_analytics. It allows you
track the 100% of your traces to have a full visilibity about
what's going on.

We add this new feature to support it. You only need to add in
the tags the key-value: `:analytics_event: true`.
@baquiax
Copy link
Contributor Author

baquiax commented Apr 23, 2020

@zachdaniel @GregMefford I hope this PR accomplish the standard on the package.

@zachdaniel
Copy link
Member

@baquiax this looks good to me, have you had a chance to confirm that it works as expected in datadog?

@baquiax
Copy link
Contributor Author

baquiax commented Apr 23, 2020

Thanks for reply @zachdaniel

Yes, I did. Here I attach a screen of my last tests.

image

@zachdaniel zachdaniel merged commit 78a30e4 into spandex-project:master Apr 23, 2020
@zachdaniel
Copy link
Member

Thank you for your contribution!

@baquiax
Copy link
Contributor Author

baquiax commented Apr 24, 2020

You are welcome @zachdaniel , thanks to you for build this project. I'll create another PR adding examples of how to use this dep.

@GregMefford
Copy link
Member

Thank you so much for taking the time to fix and test this! I’ve been meaning to look into this for a long time and just haven’t gotten the time yet! 🚀❤️

@baquiax baquiax deleted the feature/analytics-events branch April 24, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants