Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set_response_header breaking openapi doc rendering #977

Merged
merged 30 commits into from
Oct 27, 2024

Conversation

VishnuSanal
Copy link
Contributor

Description

This PR fixes #976

Summary

This PR fixes set_response_header breaking openapi doc rendering

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Oct 7, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Oct 7, 2024

CodSpeed Performance Report

Merging #977 will not alter performance

Comparing VishnuSanal:fix-content-type-openapi (c43ef44) with main (40f7f0a)

Summary

✅ 145 untouched benchmarks

@VishnuSanal
Copy link
Contributor Author

@kigawas can you have a look here?

src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
robyn/__init__.py Outdated Show resolved Hide resolved
robyn/robyn.pyi Outdated Show resolved Hide resolved
robyn/__init__.py Outdated Show resolved Hide resolved
robyn/__init__.py Outdated Show resolved Hide resolved
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 1:34pm

robyn/robyn.pyi Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
robyn/robyn.pyi Outdated Show resolved Hide resolved
robyn/processpool.py Outdated Show resolved Hide resolved
robyn/processpool.py Outdated Show resolved Hide resolved
robyn/processpool.py Outdated Show resolved Hide resolved
robyn/processpool.py Outdated Show resolved Hide resolved
robyn/processpool.py Outdated Show resolved Hide resolved
robyn/processpool.py Outdated Show resolved Hide resolved
robyn/processpool.py Outdated Show resolved Hide resolved
robyn/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VishnuSanal

I have some follow ups

Co-authored-by: Sanskar Jethi <29942790+sansyrox@users.noreply.github.com>
@sansyrox
Copy link
Member

Hey @VishnuSanal ,

Can you fetch the latest changes here?

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Good job @VishnuSanal

@sansyrox sansyrox merged commit deea29a into sparckles:main Oct 27, 2024
60 checks passed
@VishnuSanal VishnuSanal deleted the fix-content-type-openapi branch October 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.set_response_headerwill break Openapi doc rendering
3 participants