Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update --fast defaults #989

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

VishnuSanal
Copy link
Contributor

Description

This PR fixes #958

Summary

This PR does update --fast default values for --processes & --workers

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Oct 21, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #989 will not alter performance

Comparing VishnuSanal:fast-defaults (4bf596c) with main (42f87f8)

Summary

✅ 145 untouched benchmarks

robyn/argument_parser.py Outdated Show resolved Hide resolved
Co-authored-by: Sanskar Jethi <29942790+sansyrox@users.noreply.github.com>
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 5:30pm

@sansyrox sansyrox changed the title chore: update fast defaults chore: update --fast defaults Oct 23, 2024
@sansyrox sansyrox merged commit 6595587 into sparckles:main Oct 23, 2024
50 of 60 checks passed
@VishnuSanal VishnuSanal deleted the fast-defaults branch October 24, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change --fast defaults
2 participants