Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: build starfyre #15

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Conversation

Mikcl
Copy link
Contributor

@Mikcl Mikcl commented Feb 15, 2023

Updates the Makefile to make build the starfyre source.

make in-dev will now actually build the current starfyre and make it available in test-application.

There are still a few limitations:

  • requiring to have python, rust, cargo, emcc on your machine but good place to start.
  • Not sure how to sync emscripten versions. I think pyo3 needs to be built with the same version for loading the starfyre-0.4.1-cp310-cp310-**emscripten_3_1_27**_wasm32.whl wheel

Follow ups, remove files:
package.json - unused.
cargo.lock - iiuc, this shouldnt be in the source control for libraries.
poetry.lock - we dont seem to use poetry at the moment?
build.sh - unused.

@Mikcl
Copy link
Contributor Author

Mikcl commented Feb 16, 2023

blocked on #16

@sansyrox
Copy link
Member

Not sure how to sync emscripten versions. I think pyo3 needs to be built with the same version for loading the starfyre-0.4.1-cp310-cp310-emscripten_3_1_27_wasm32.whl wheel

This is something that I am not even sure of. But we can assume 27 for now.

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Great work! Thanks @Mikcl

@sansyrox sansyrox merged commit d276bb8 into sparckles:main Feb 16, 2023
@Mikcl
Copy link
Contributor Author

Mikcl commented Feb 16, 2023

post merge for issue tracking: Towards #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants