Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BiseoError 생성 시 serialize 메서드가 존재하지 않음 #419

Closed
1 task done
withSang opened this issue Oct 24, 2023 · 0 comments · Fixed by #420
Closed
1 task done

BiseoError 생성 시 serialize 메서드가 존재하지 않음 #419

withSang opened this issue Oct 24, 2023 · 0 comments · Fixed by #420
Assignees
@withSang @SnowSuno
Labels
bug Something isn't working

Comments

@withSang
Copy link
Member

withSang commented Oct 24, 2023 •
edited
Loading

이슈 내용 *

biseo-api의 libs/error.ts에서 BiseoError 클래스를 Error 클래스를 extend해 사용하고 있는데, TypeScript 2.1부터 Error 클래스를 extend할 수 없다고 합니다(microsoft/TypeScript#12123 이슈 참조).

사실 Error 클래스를 extend할 이유가 없어서(클라이언트에만 전달되는 에러입니다 - 감사해요 @SnowSuno ), BiseoError가 Error를 extend하지 않게 수정해야 합니다.

스크린샷

image
BiseoError의 constructor가 제대로 실행되지 않아 serialize 메서드가 존재하지 않습니다.

관련 Task *

  • BiseoError 클래스 정의 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@withSang withSang

@SnowSuno SnowSuno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BiseoError 생성 시 serialize 메서드가 존재하지 않음 sparcs-kaist/biseo
2 participants
@withSang @SnowSuno