BiseoError 생성 시 serialize 메서드가 존재하지 않음 #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Soonho Kwon <percy3368@gmail.com>
1 task
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
아 BiseoError는 Error가 아닌 literal이라 throw시 오류가 발생하군요..... |
|
스테이징된 파일들에 대해서만 컨벤션 검사가 이루어지니 PR을 올린 이후에야 발견하게 되는 오류들이 있군요.. |
|
또 새로운 걸 배웠군 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It fixes #419
biseo-api의
libs/error.ts에서 BiseoError 클래스를 Error 클래스를 extend해 사용하고 있는데, TypeScript 2.1부터 Error 클래스를 extend할 수 없다고 합니다(microsoft/TypeScript#12123 이슈 참조).사실 Error 클래스를 extend할 이유가 없어서(클라이언트에만 전달되는 에러입니다 - 감사해요 @SnowSuno ), BiseoError가 Error를 extend하지 않게 수정하였습니다.
이후 Task *