Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Channel Talk #181

Merged
merged 18 commits into from
Aug 14, 2024
Merged

Add Channel Talk #181

merged 18 commits into from
Aug 14, 2024

Conversation

happycastle114
Copy link
Contributor

No description provided.

@happycastle114 happycastle114 linked an issue Aug 12, 2024 that may be closed by this pull request
[FEAT] Channel Talk #180
Closed
@happycastle114 happycastle114 changed the title Feat Add Channel Talk feat Add Channel Talk Aug 12, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.37152% with 128 lines in your changes missing coverage. Please review.

Project coverage is 31.12%. Comparing base (42d492b) to head (f1bba1b).

Files Patch % Lines
lib/widgets/pop_up.dart 0.00% 87 Missing ⚠️
lib/widgets/lecture_search.dart 75.92% 13 Missing ⚠️
lib/pages/lecture_search_page.dart 83.82% 11 Missing ⚠️
lib/pages/course_search_page.dart 87.69% 8 Missing ⚠️
lib/main.dart 0.00% 5 Missing ⚠️
lib/widgets/dropdown.dart 90.90% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   31.08%   31.12%   +0.04%     
==========================================
  Files          80       80              
  Lines        4809     4822      +13     
==========================================
+ Hits         1495     1501       +6     
- Misses       3314     3321       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@happycastle114 happycastle114 added the feat New feature or request label Aug 13, 2024
@happycastle114 happycastle114 requested review from s8ngyu and sboh1214 and removed request for s8ngyu August 13, 2024 09:56
@github-actions github-actions bot added size/xl and removed size/m labels Aug 13, 2024
@happycastle114 happycastle114 requested a review from s8ngyu August 14, 2024 04:25
@sboh1214 sboh1214 self-assigned this Aug 14, 2024
sboh1214
sboh1214 requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요~

android/app/build.gradle Outdated Show resolved Hide resolved
android/app/build.gradle Outdated Show resolved Hide resolved
ios/Runner/Info.plist Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@happycastle114 happycastle114 self-assigned this Aug 14, 2024
@sboh1214 sboh1214 changed the title feat Add Channel Talk Add Channel Talk Aug 14, 2024
sboh1214
sboh1214 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simon Thumbs

@sboh1214 sboh1214 merged commit f557a3b into main Aug 14, 2024
8 checks passed
@sboh1214 sboh1214 deleted the #180-feat-channel-talk branch August 14, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8ngyu s8ngyu s8ngyu approved these changes

@sboh1214 sboh1214 sboh1214 approved these changes

Assignees

@sboh1214 sboh1214

@happycastle114 happycastle114

Labels
feat New feature or request size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Channel Talk
3 participants
@happycastle114 @sboh1214 @s8ngyu