Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #184, fix modal with deleting timetable #193

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

callasio
Copy link
Contributor

@callasio callasio commented Sep 7, 2024

Resolve Issue #184

스크린샷

삭제 확인 모달 삭제 불가 모달
Simulator Screenshot - iPhone 16 Pro - 2024-09-15 at 02 57 03 Simulator Screenshot - iPhone 16 Pro - 2024-09-15 at 02 57 21

@callasio callasio added the bug Something isn't working label Sep 7, 2024
@callasio callasio self-assigned this Sep 7, 2024
@github-actions github-actions bot added the size/s label Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 31.10%. Comparing base (575f342) to head (d0cb5ef).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/timetable_page.dart 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   31.13%   31.10%   -0.03%     
==========================================
  Files          80       80              
  Lines        4847     4851       +4     
==========================================
  Hits         1509     1509              
- Misses       3338     3342       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sboh1214
Copy link
Contributor

sboh1214 commented Sep 10, 2024

@callasio

아래 링크 참조하시면 됩니다.

https://stackoverflow.com/questions/69568862/flutter-showdialog-is-not-shown-on-popupmenuitem-tap

WidgetsBinding.instance.addPostFrameCallback((_) {});

@callasio callasio marked this pull request as ready for review September 11, 2024 02:24
@sboh1214 sboh1214 force-pushed the 184-time-table-delete branch from 563f6dd to d0cb5ef Compare September 14, 2024 08:19
@sboh1214 sboh1214 linked an issue Sep 14, 2024 that may be closed by this pull request
@sboh1214 sboh1214 changed the title [BUG] Can't delete time table Fix #184, fix modal with deleting timetable Sep 14, 2024
@sboh1214 sboh1214 merged commit b7b2b06 into main Sep 14, 2024
6 of 8 checks passed
@sboh1214 sboh1214 deleted the 184-time-table-delete branch September 14, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't delete time table
2 participants