Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promotion notification consent dialog #210

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sparcscasio
Copy link

No description provided.

@sparcscasio sparcscasio requested a review from sboh1214 January 9, 2025 13:44
@github-actions github-actions bot added the size/m label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 14.54545% with 47 lines in your changes missing coverage. Please review.

Project coverage is 38.60%. Comparing base (e700bf7) to head (636ae0f).

Files with missing lines Patch % Lines
lib/widgets/otl_dialog.dart 0.00% 35 Missing ⚠️
lib/providers/settings_model.dart 30.00% 7 Missing ⚠️
lib/pages/settings_page.dart 55.55% 4 Missing ⚠️
lib/main.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   38.85%   38.60%   -0.26%     
==========================================
  Files          80       80              
  Lines        4900     4953      +53     
==========================================
+ Hits         1904     1912       +8     
- Misses       2996     3041      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sboh1214 sboh1214 force-pushed the feat@promotion-notification branch from 445e286 to a6b4722 Compare January 9, 2025 15:53
@sboh1214 sboh1214 added feat New feature or request g11n i18n and l10n labels Jan 9, 2025
@sboh1214 sboh1214 changed the title feat: add promotion consent Add promotion notification consent dialog Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request g11n i18n and l10n size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants