Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sanitizes
Particle.publish()
overloads, making it possible to specify one or two flags for any variant of this method. The PR also implements a generic type-safe wrapper for enum-based flags, akaparticle::Flags<T>
, which enables regular syntax for ORed flag combinations as an option:Fixes #1201 and #1194.
Doneness:
Bug fixes
[PR #1236]
[Fixes #1201]
[Fixes #1194]
SanitizedParticle.publish()
overloads.Enhancements
[PR #1236]
[Fixes #1201]
[Fixes #1194]
Added type-safe wrapper for enum-based flags forParticle.publish()
which enables logical OR'ed flag combinationsPRIVATE | WITH_ACK