platform/#3349: allow minor version in MySQL configuration

[Monska85]

PR Type

Enhancement

---

Description

• Added support for MySQL minor versions in database configuration
• Modified version validation in Terraform to check only major version using startswith
• Updated shell script to handle minor versions in MySQL version checks
• Maintains backward compatibility with existing MySQL 5.7 and 8.0 major versions

---

Changes walkthrough 📝

Relevant files

Enhancement

main.tf Update MySQL version validation to support minor versions main.tf Modified database version validation to support minor versions by using startswith condition instead of exact match +1/-1      execute_sql.sh Update MySQL version checks in SQL execution script            scripts/execute_sql.sh Updated MySQL version checks to match only major version using string substring Modified version comparison for both MySQL 5.7 and 8.0 to support minor versions +2/-2

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Version Check The substring check for MySQL version using ${MYSQL_VERSION:0:9} assumes a specific string format. Validate that this will work correctly with all possible version string formats from the cloud provider. if [ "${MYSQL_VERSION:0:9}" = "MYSQL_5_7" ]; then mysql --host=${CLOUDSQL_PROXY_HOST} --port=${CLOUDSQL_PROXY_PORT} --user=${CLOUDSQL_PRIVILEGED_USER_NAME} --password=${CLOUDSQL_PRIVILEGED_USER_PASSWORD} --execute="REVOKE ALL PRIVILEGES, GRANT OPTION FROM '${USER}'@'${USER_HOST}'; GRANT ALL ON ${DATABASE}.* TO ${USER}@'${USER_HOST}';" fi if [ "${MYSQL_VERSION:0:9}" = "MYSQL_8_0" ]; then mysql --host=${CLOUDSQL_PROXY_HOST} --port=${CLOUDSQL_PROXY_PORT} --user=${CLOUDSQL_PRIVILEGED_USER_NAME} --password=${CLOUDSQL_PRIVILEGED_USER_PASSWORD} --execute="REVOKE cloudsqlsuperuser FROM '${USER}'@'${USER_HOST}'; GRANT ALL ON ${DATABASE}.* TO ${USER}@'${USER_HOST}';"

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add error handling for unsupported database versions to prevent silent failures Add an else clause to handle unsupported MySQL versions, preventing silent failures when an unexpected version is encountered. scripts/execute_sql.sh [23-29] if [ "${MYSQL_VERSION:0:9}" = "MYSQL_5_7" ]; then mysql --host=${CLOUDSQL_PROXY_HOST} --port=${CLOUDSQL_PROXY_PORT} --user=${CLOUDSQL_PRIVILEGED_USER_NAME} --password=${CLOUDSQL_PRIVILEGED_USER_PASSWORD} --execute="REVOKE ALL PRIVILEGES, GRANT OPTION FROM '${USER}'@'${USER_HOST}'; GRANT ALL ON ${DATABASE}.* TO ${USER}@'${USER_HOST}';" +elif [ "${MYSQL_VERSION:0:9}" = "MYSQL_8_0" ]; then + mysql --host=${CLOUDSQL_PROXY_HOST} --port=${CLOUDSQL_PROXY_PORT} --user=${CLOUDSQL_PRIVILEGED_USER_NAME} --password=${CLOUDSQL_PRIVILEGED_USER_PASSWORD} --execute="REVOKE cloudsqlsuperuser FROM '${USER}'@'${USER_HOST}'; GRANT ALL ON ${DATABASE}.* TO ${USER}@'${USER_HOST}';" +else + echo "Error: Unsupported MySQL version: ${MYSQL_VERSION}" + exit 1 fi -if [ "${MYSQL_VERSION:0:9}" = "MYSQL_8_0" ]; then - mysql --host=${CLOUDSQL_PROXY_HOST} --port=${CLOUDSQL_PROXY_PORT} --user=${CLOUDSQL_PRIVILEGED_USER_NAME} --password=${CLOUDSQL_PRIVILEGED_USER_PASSWORD} --execute="REVOKE cloudsqlsuperuser FROM '${USER}'@'${USER_HOST}'; GRANT ALL ON ${DATABASE}.* TO ${USER}@'${USER_HOST}';" -fi - Suggestion importance[1-10]: 9 Why: The suggestion adds crucial error handling for unsupported MySQL versions, preventing silent failures and improving system reliability. This is particularly important as the code deals with database privileges and security.	9