Fix OneOf and AugmentationsSequence handling of Mask, Keypoints, and Bounding Boxes; resolve apply_phase unpacking error #448
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused an error when unpacking result tuple in augmentationpipeline's apply_phase.
|
@AhmedDusuki Could you run the pre-commit and update the pull request again? Install pre-commit: From the prompt, navigate into the augraphy repo, and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on #446 by @Travvy88, which addresses handling Mask, Keypoints, and Bounding Boxes for
OneOfandAugmentationsSequence. However, the original PR causes an error whenmask=None,keypoints=None, andbounding_boxes=Nonedue to theAugmentationsPipeline'sapply_phasefunction unpacking theresulttuple (expecting 2 values but receiving 4 fromAugmentationsSequence).AugmentationSequenceto include additional information in the result tuple only when(mask is not None) or (keypoints is not None) or (bounding_boxes is not None).