-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Text Strikethrough #75
Conversation
There are a lot of changes here. It looks like some of the pre-commit changes to the code are spread across several commits somehow. I have a few questions:
I'm happy to merge the new |
I guess the other files were not modified by pre-commit earlier and running my pre-commit changed those. I'll look for some solution for this tonight |
I guess I should've pushed my changes only which were related to strikethrough.py. |
Where did you see this error?
In the future, you can
Yeah, let's try to keep commits small and only do a few things at a time. Big PRs are hard to look through 😁 |
If you submit a pull request for just the changes related to |
Added Text Strikethrough #63 in
ink
phase. The pencil texture has not been added yet. I am waiting for it to be available in shared lib.