New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing getters #5

Closed

karelv opened this issue Aug 30, 2021 · 1 comment · Fixed by #6

karelv commented Aug 30, 2021

Hello,

May I kindly ask you to add getter functions?

getSlaveAddress ==> return the private variable _deviceAddress
getADCMode ==> return the private variable _wireMode

Thanks.

PaulZC added a commit that referenced this issue


          Add getDeviceAddress and getWireMode as requested in #5

0cb71ec

Collaborator

PaulZC commented Aug 31, 2021

Hi @karelv ,
Good suggestion. I will add these in v1.0.2.
Best wishes,
Paul

PaulZC linked a pull request

that will close this issue

Merged

PaulZC closed this as completed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment