Include math.h #49
Merged
Include math.h #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkFunBME280.cpp uses math functions pow, log and log10. This produces errors such as "pow was not declared in this scope". Found this while packaging this library for RIOT-OS. The library works with Arduino because math.h is included somewhere else. But I think it's better or more correct to include the headers for the functions used. Fixes sparkfun#48
|
Shouldn't this be included in the header that includes the compile guards? Yes, math.h should have it's own guards but it's best practice to put math.h inside SparkFunBME280.h, no? |
|
A quick search for best practice makes me think it's the opposite: include where it's used, e.g. https://stackoverflow.com/a/3002124/9055637 But if you prefer I will move the include to the header file. |
|
e.g. in my cpp file I have: If |
|
I stand corrected! Thank you for the education. It's a simple change but I'll test this out with the other PRs later this week. |
|
Thanks again! |
jdavid
added a commit
to spectraphilic/wsn_riot
that referenced
this pull request
Dec 31, 2020
No need patching anymore, sparkfun/SparkFun_BME280_Arduino_Library#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SparkFunBME280.cppuses math functionspow,logandlog10. This produceserrors such as "pow was not declared in this scope". Found this while
packaging this library for RIOT-OS.
The library works with Arduino because
math.his included somewhereelse. But I think it's better or more correct to include the headers for
the functions used.
Fixes #48