Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile warning because boolean typedef is deprecated in some Arduino cores #61

Closed
lwestfall opened this issue May 9, 2021 · 2 comments
Closed

Compile warning because boolean typedef is deprecated in some Arduino cores #61

lwestfall opened this issue May 9, 2021 · 2 comments

Comments

@lwestfall
Copy link
Contributor

Some Arduino cores have marked the boolean typedef as deprecated (see this issue). This results in a warning on compilation in STM32duino due to the following line:

SparkFun_ICM-20948_ArduinoLibrary/src/ICM_20948.h

Line 24 in ffca57b

boolean _printDebug = false; //Flag to print the serial commands we are sending to the Serial port for debug

Do we have to use the boolean alias? Can we change this to bool instead?

I can submit a PR if this change is desired.
@PaulZC
Copy link
Contributor

PaulZC commented May 10, 2021

Hi Luke (@lwestfall ),
Sure, we can change that to bool. Yes, please do send us a PR. Guidelines are here.
Best wishes,
Paul

@lwestfall lwestfall mentioned this issue May 10, 2021
Merged
@PaulZC
Copy link
Contributor

PaulZC commented May 11, 2021

Resolved by #62 - thank you @lwestfall

@PaulZC PaulZC closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulZC @lwestfall