update comment to reflect use of NAU7802_SPS_80 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank Nick (@dankamongmen ), I'll merge this, but am going to rename the main branch first. Cheers, |
|
Oh. I don't have the privileges... @nseidle : can you rename the main branch please. |
|
Done! |
|
Excellent - thank you. Merging this into release_candidate... |
|
thanks! are you interested in more invasive changes? i spent last night writing an esp-idf component, and think i have some issues with the Arduino implementation: https://github.com/dankamongmen/nau7802-esp-idf |
|
Hi Nick, If you think we've missed something, a PR is always very welcome... Many thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment here claims to select 10 samples per second (the default according to the data sheet), but the code is selecting 80. Update the comment.