Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ed25519 support to XPC branch #1423

Merged
merged 7 commits into from
Aug 29, 2020
Merged

Add ed25519 support to XPC branch #1423

merged 7 commits into from
Aug 29, 2020

Conversation

tonyarnold
Copy link
Contributor

Please merge #1422 before this branch.

This is presently a work in progress to bring forward the ed25519 changes from master to the XPC and UI separation branch.

@DivineDominion
Copy link
Contributor

DivineDominion commented Jun 26, 2019 •
edited
Loading

@tonyarnold What do we need to do to make this less a WIP and make it merge-able?

@tonyarnold
Copy link
Contributor Author

@DivineDominion buy me a TARDIS and a Mac Pro?

I need to find some time to finish moving the changes over. I've been quite busy is all.

@kornelski kornelski mentioned this pull request Aug 8, 2019
Closed
@kornelski
Copy link
Member

How's this going?

@tonyarnold
Copy link
Contributor Author

Honestly, I've not had time to spend on this. I'll see what I can do in the next few days.

@kornelski kornelski mentioned this pull request Dec 15, 2019
Closed
8 tasks
@tonyarnold
Add ed25519 as a static library to the project
6c90c08 
# Conflicts:
#	Sparkle.xcodeproj/project.pbxproj
@tonyarnold
Update generate_appcast command line tool to support ed25519 signatures
9118cb6 
This code has been ported directly from `master`.

Co-authored-by: Kornel Lesiński <github@pornel.net>

# Conflicts:
#	Sparkle.xcodeproj/project.pbxproj
@tonyarnold
Add generate_keys command line tool
ee0a9c9 
This code has been ported directly from `master`.

Co-authored-by: Kornel Lesiński <github@pornel.net>

# Conflicts:
#	Sparkle.xcodeproj/project.pbxproj
@tonyarnold
Add sign_update command line tool
3fd125f 
This code has been ported directly from `master`.

Co-authored-by: Kornel Lesiński <github@pornel.net>

# Conflicts:
#	Sparkle.xcodeproj/project.pbxproj
@tonyarnold
Add Xcode group for the command line tools
0731b6e 
# Conflicts:
#	Sparkle.xcodeproj/project.pbxproj
@tonyarnold
Update the code signing verifier tests to match what is on master
9d84b40
@belkadan
Copy link
Contributor

I shoved through the framework side of this by looking at @kornelski's commits from 1.21.0, plus the work on SUSignatureVerifier.m and SUUpdateValidator.m since then. It would definitely need review from someone else, though.

https://github.com/belkadan/Sparkle/tree/feature/ed25519

@tonyarnold
Copy link
Contributor Author

@belkadan want to open a PR from your end? Happy to manage this any which way (including just stepping out of the way), given how little time I've had to work on this.

@tonyarnold
Copy link
Contributor Author

Oh, I'm also happy to help review 👍

@belkadan
Copy link
Contributor

belkadan commented Feb 20, 2020 •
edited
Loading

@kornelski, any preferences?

@belkadan belkadan mentioned this pull request Feb 21, 2020
Closed
@belkadan
Copy link
Contributor

Well, I opened #1553, and that way we can get started with review, at least. Happy to change to whatever process ends up best.

@kornelski kornelski merged commit 6b2af48 into sparkle-project:ui-separation-and-xpc Aug 29, 2020
@tonyarnold tonyarnold deleted the feature/ed25519 branch December 1, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyarnold @DivineDominion @kornelski @belkadan