feat: properly compare versions with commit SHA #1504
Conversation
|
Yeah, this commit breaks version comparison in my project, because my versions are based on a Git tag:
|
|
I'm surprised that your scheme has worked before. I don't think Sparkle should be adding support for more complicated versions. Your case of having the same version for all releases is an edge case. You should be increasing the version, not just commit count. |
|
How about I just increment a decimal point by one, per every published release, forever more? Is that sufficient? |
|
Yes, if you keep incrementing the "patch" part of the version, it'll be fine. These are 3 numbers, not a decimal fraction. |
|
I changed my versioning scheme, and it works out fine for Sparkle 1.23.0. The only issues I've had so far now are with my own maintenance scripts. |
On second thought I realized we can support this without doing any date comparison because the code just picks the first item if two are equal.
Port #1504 (dash separators in version strings) to 2.x
When two versions have the same major/minor/patch numbers (eg:
1.5.5-335d3e2and1.5.5-a655360), the newer version is used (determined by itsdateproperty).