Fixes sync from 1.x #1722
Merged
Fixes sync from 1.x #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ients polling too frequently" sparkle-project#1135
…roject#1515) • Updated error dialog code in SUBasicUpdateDriver, and created a local variable to reuse `[aHost name]`. • Updated content of Sparkle.strings files, splitting existing affected translations into 2 chunks each. • Fixed the Catalan translation, which was using an old string key. • Removed a few unnecessary comments in the Polish translation.
I may have accidentally removed this.
When changing the name of an app, there's a couple things to do in order
to ensure auto-updates still work:
1. set SUBundle Name. This basically tells Sparkle "ey, expect an app
of {SUBundleName}.(app|pkg) instead of the normal name."
2. set `SPARKLE_NORMALIZE_INSTALLED_APPLICATION_NAME` in
commonConfig.xccconfig to reset the name of the app.
in (2), we always used the host's bundle name, instead of checking to
see if SUBundleName was set, which means normalization doesn't work as
expected during app name changes.
Masked sysctl hw.cputype value when evaluating the CPU type. Used macros from mach/machine.h instead of magic numbers. Added support for ARM in evaluation of hw.cpusubtype.
This was referenced Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of commits / changes here are syncing bug fixes / parity strictly, not minor API / feature changes.