-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better appcast selection #1850
Merged
Merged
Better appcast selection #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prefer using the latest update that passes minimumAutoupdateVersion When an update is not found: * Find latest appcast item that may fail min/max OS * Report that user cannot install an update due to unsupported OS
This method will not be invoked for appcast with zero items. Clients must pick best item and cannot pick "no items."
kornelski
approved these changes
May 3, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of change
Testing
I tested and verified my change by using one or multiple of these methods:
Tested:
Skipped update is appropriately skipped
Update that passes minimumAutoupdateVersion is preferred
Update that fails min/max OS lets user know their OS is too old or too new.
Added some unit tests for testing minimum auto update version and skipping versions there.
macOS version tested: 11.3 (20E232)