Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tar.xz files with built-in tar and remove bzip2 fallback #2535

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Mar 31, 2024

This removes usages of non-built-in xz utility when it was not needed for creating a Sparkle binary distribution. This also removes the fall back to bzip2 and always create .tar.xz distribution.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested make release outputted identical binaries as before these changes (only dSYM files differed). make-release-package.sh tests code signing integrity of extracted products are valid as well. The tar.xz file created is a bit bigger than before (few MB more) but this shouldn't really matter much in practice.

macOS version tested: 14.4.1 (23E224)

@zorgiepoo zorgiepoo added this to the 2.6.1 milestone Mar 31, 2024
@zorgiepoo zorgiepoo merged commit d30adc8 into 2.x Mar 31, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the dont-use-xz branch March 31, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant