Skip installing the framework by default — fixes #419 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vslavik
added a commit
to vslavik/poedit
that referenced
this pull request
Dec 2, 2014
So, using upstream Sparkle as a submodule was good while it lasted... which wasn't long. Recent versions of Sparkle break Xcode archiving workflow and the relevant bugs and PRs are still open, so a resolution doesn't seem likely in foreseeable future. Use own fork mostly identical, with tonyarnold's SKIP_INSTALL pull request merged in. See sparkle-project/Sparkle#419 and sparkle-project/Sparkle#446 Mostly reverts 231967a.
|
Not to push a point, but any chance this could be merged or rejected so I know what I need to do at my end? |
|
@jakepetroules what do you think? |
Closed
kornelski
added a commit
that referenced
this pull request
Jan 15, 2015
Skip installing the framework by default — fixes #419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.