Prevent OS command injection #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
flavorjones
force-pushed
the
fix_command_injection
branch
from
2ada035
to
5856fc8
Compare
|
Rebased onto current |
Also add general test coverage for FileResponse#read_body Related to GHSA-qrqm-fpv6-6r8g
- change implicit Kernel.open to ::File.open - replace `eval` with `define_method`
flavorjones
force-pushed
the
fix_command_injection
branch
from
5856fc8
to
5b30aed
Compare
|
I've pushed several more commits to remove additional instances of implicit |
|
I've created a security advisory at https://github.com/sparklemotion/mechanize/security/advisories/GHSA-qrqm-fpv6-6r8g#advisory-comment-64402. As soon as we are assigned a CVE, I'll merge this branch and cut a release, which will be v2.7.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #547