Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use addressable gem to escape uri with fragment properly #569

Closed
wants to merge 2 commits into from

Conversation

terryyin
Copy link
Contributor

@terryyin terryyin commented Feb 6, 2021

When the fragment (part that's after #) contains characters that need to be escaped, WEBrick::HTTPUtils.escape will wrongly escape the # as well. That will break the original uri. The Addressable gem can do the escape properly.

@flavorjones
Copy link
Member

@terryyin Thank you for this contribution! Merging manually to include some commits I would have liked to add. (You may want to consider allowing maintainers push access to your PR branches in the future.)

@flavorjones flavorjones closed this Feb 7, 2021
@flavorjones
Copy link
Member

Merged onto master as d9b305d. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants