Update user agent strings for agent aliases #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this! I've kicked off CI and I think this update (and the example which helps keep us up to date) is very helpful. |
flavorjones
force-pushed
the
add-example-to-fetch-latest-user-agents
branch
from
2553cb7
to
18b7efd
Compare
|
Looks good. I updated the docstring and will merge this shortly. |
|
Thank you so much for docstring update, and thank you for the review and this PR merging! |
|
Just shipped in Release 2.9.1 / 2023-04-17 · sparklemotion/mechanize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think user agent aliases of Mechanize looks useful for developer, but actually unusable because they are very old.
They looks need to be updated.
In addition, this PR contains an example to fetch latest user agents from WhatIsMyBrowser.com.
Especially, The service provide APIs and it requires payment, so public web site content may be a preview.
Therefore, to avoid pirating, I did not fully automate this process to update user agent aliases.