Skip to content

Commit

Permalink
dev: update rubocop todo list
Browse files Browse the repository at this point in the history
because some new rubocop-performance rules kicked in
  • Loading branch information
flavorjones committed Jan 3, 2022
1 parent f3af677 commit af58bbc
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2021-10-26 07:27:19 UTC using RuboCop version 1.22.2.
# on 2022-01-03 20:31:05 UTC using RuboCop version 1.24.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -13,7 +13,7 @@ Lint/IneffectiveAccessModifier:
- 'lib/nokogiri/html5/document.rb'
- 'lib/nokogiri/xml/document.rb'

# Offense count: 11
# Offense count: 5
Lint/MissingSuper:
Exclude:
- 'lib/nokogiri/html4/document_fragment.rb'
Expand Down Expand Up @@ -50,16 +50,24 @@ Performance/CollectionLiteralInLoop:
- 'test/xml/test_dtd_encoding.rb'
- 'test/xml/test_node_reparenting.rb'

# Offense count: 11
# Cop supports --auto-correct.
Performance/StringIdentifierArgument:
Exclude:
- 'lib/nokogiri/html5.rb'
- 'test/html5/test_encoding.rb'
- 'test/test_css_cache.rb'
- 'test/test_memory_leak.rb'
- 'test/xml/test_builder.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Performance/StringInclude:
Exclude:
- 'lib/nokogiri/css/xpath_visitor.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Performance/TimesMap:
Exclude:
- 'test/html5/test_nokogumbo.rb'
Expand All @@ -82,7 +90,7 @@ Style/MissingRespondToMissing:
Exclude:
- 'lib/nokogiri/xml/builder.rb'

# Offense count: 85
# Offense count: 78
# Cop supports --auto-correct.
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Expand Down

0 comments on commit af58bbc

Please sign in to comment.