Nokogiri::XML.parse() supports argument forwarding

Related to https://github.com/sparklemotion/nokogiri#3323
sparklemotion · Nov 14, 2024 · c2f27cf · c2f27cf
1 parent 8fba8c8
commit c2f27cf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/nokogiri/xml.rb b/lib/nokogiri/xml.rb
@@ -33,8 +33,8 @@ def Reader(string_or_io, url = nil, encoding = nil, options = ParseOptions::STRI
 
       ###
       # Parse XML.  Convenience method for Nokogiri::XML::Document.parse
-      def parse(thing, url = nil, encoding = nil, options = ParseOptions::DEFAULT_XML, &block)
-        Document.parse(thing, url, encoding, options, &block)
+      def parse(...)
+        Document.parse(...)
       end
 
       ####

diff --git a/test/xml/test_document.rb b/test/xml/test_document.rb
@@ -1101,6 +1101,13 @@ def test_can_be_closed
                 end
                 assert_nil(error.path)
               end
+
+              it "raises exception on parse error with kwargs" do
+                error = assert_raises Nokogiri::SyntaxError do
+                  Nokogiri::XML.parse(input, options: parse_options)
+                end
+                assert_nil(error.path)
+              end
             end
 
             describe "default options" do
@@ -1122,6 +1129,12 @@ def test_can_be_closed
                   Nokogiri::XML.parse(input, nil, nil, parse_options)
                 end
               end
+
+              it "raises exception on parse error with kwargs" do
+                assert_raises Nokogiri::SyntaxError do
+                  Nokogiri::XML.parse(input, options: parse_options)
+                end
+              end
             end
 
             describe "default options" do