Fix segfault when doing marking and doc is not a document node #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem where the doc node can actually also be a XML_DOCUMENT_FRAG_NODE. In that case it's structured like a node which means it stores a VALUE inside _private. This checks the type of the code and uses the correct marking for the specific cases. Fixes #939
|
Is there anything that would hold back this being merged? I've had several people confirm this fixes segfaults on Rubinius when using Nokogiri. |
tenderlove
added a commit
that referenced
this pull request
Dec 9, 2013
…ocument_nodes Fix segfault when doing marking and doc is not a document node
|
@tenderlove Thanks for merging :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where the doc node can actually also be a
XML_DOCUMENT_FRAG_NODE. In that case it's structured like a node which
means it stores a VALUE inside _private.
This checks the type of the code and uses the correct marking for the
specific cases.
Fixes #939