Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit Racc depenency. #2104

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Add explicit Racc depenency. #2104

merged 2 commits into from
Oct 27, 2020

Commits on Oct 26, 2020

  1. Add explicit Racc depenency. 

    Nokogiri always have had dependency on Racc, but it was never stated
explicitly. This is possible issue for several reasons:

1) There is no way RubyGems/Bundler could avoid loading wrong version of
   Racc if other package in application specifies different version of
   Racc then Nokogiri needs.
2) If there is released incompatible Racc 2.x, all old versions of
   Nokogiri will be broken just because it does not specify its
   dependencies properly.
3) If Ruby decides to drop Racc from StdLib, all Nokogiri versions will
   be broken (unnoticeably). Or Ruby will be forced to carry Racc around
   around although it is possibly obsolete.

Fixes sparklemotion#1988
    @voxik @flavorjones
    voxik authored and flavorjones committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5cefe58 View commit details
    Browse the repository at this point in the history

  2. doc: update CHANGELOG to note explicit racc dependency

    @flavorjones
    flavorjones committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    e0d2591 View commit details
    Browse the repository at this point in the history