Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(upstream): run against latest html5lib-tests master #2288

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

As the html5lib-tests repo changes over time, I think it might be helpful to automatically run against the latest so that if any failures are introduced, we can address them proactively.

This PR adds a job to the upstream CI pipeline, which runs periodically every few days, running against the latest versions of some of Nokogiri's dependencies.

I'll rely on @stevecheckoway to tell me if this is actually useful.

Have you included adequate test coverage?

This PR introduces new test coverage.

Does this change affect the behavior of either the C or the Java implementations?

No functional changes.

@flavorjones flavorjones force-pushed the flavorjones-upstream-html5lib-tests branch from 9ea9c10 to ca05768 Compare July 9, 2021 16:40
Copy link
Contributor

@stevecheckoway stevecheckoway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavorjones flavorjones merged commit 71c5822 into main Jul 9, 2021
@flavorjones flavorjones deleted the flavorjones-upstream-html5lib-tests branch July 9, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants