fix: regression with XPath attributes in CSS selectors #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it's easier to do focused test runs
This commit removes "@" from the IDENT token so that we can create a new grammar rule in the parser for XPath attributes. Fixes #2419
All attribute references end up as an :ATTRIB_NAME node without the "@" present, which simplifies the XPath visitor code.
And officially document the XPath attribute extensions to CSS selector syntax that we support. See #2419 for context
flavorjones
force-pushed
the
2419-css-at-attribute-syntax
branch
from
7a889ca to
538e11d
Compare
|
On my end I can confirm this makes Discourse specs pass again! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Issue #2419 reported that a regression in v1.13.0 that raised an
Nokogiri::XML::XPath::SyntaxErrorwhen parsing XPath attributes mixed into the CSS query, for examplenode.css("img/@href").Although this mash-up of XPath and CSS syntax previously worked unintentionally, it is now an officially supported feature and is documented as such.
Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
No.