handle upstream libxml2 changes #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've opened an upstream merge request to fix the underlying problem at https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/231 Without this check, we'd segfault. So a failing test is preferable.
|
Note that I've asked about the in-context recovery behavior upstream at (on master) in-context parsing recovery: XML vs HTML (#645) · Issues · GNOME / libxml2 · GitLab |
flavorjones
force-pushed
the
flavorjones-20231213-upstream-libxml-work
branch
from
5baaf5d to
29caf63
Compare
Fixed in abd74186 and 1c106edf. See https://gitlab.gnome.org/GNOME/libxml2/-/issues/645
flavorjones
force-pushed
the
flavorjones-20231213-upstream-libxml-work
branch
from
29caf63 to
c50d60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Upstream libxml2 test failures.
XML::Node#parsebehavior to accommodate it in a backwards-compatible fashion. See [bug] "in context" fragment parsing silently degrades functionality when XML errors are encountered #2092 which might be fixed in future versions of libxml2.Have you included adequate test coverage?
Making existing tests pass (or not segfault while we wait for an upstream fix).
Does this change affect the behavior of either the C or the Java implementations?
No.