fix: serializing an individual attribute in an HTML5 document #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevecheckoway I didn't extract the code into a separate function, but obviously will do that if you think it's best. |
flavorjones
force-pushed
the
flavorjones-3125-html5-attribute-to-html
branch
2 times, most recently
from
b9c28cd to
a84545e
Compare
Previously an exception would be raised, either "Unexpected node" or "Unsupported document node (2)" depending on the version of Nokogiri. Fixes #3125
flavorjones
force-pushed
the
flavorjones-3125-html5-attribute-to-html
branch
from
a84545e to
5ba752c
Compare
|
LGTM! The suggestion to extract the attribute serializing code to a function was just to avoid code duplication. Making a recursive call does that equally well. |
stevecheckoway
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Previously an exception would be raised, either "Unexpected node" or "Unsupported document node (2)" depending on the version of Nokogiri.
Fixes #3125
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
HTML5 is only available in CRuby.