Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes #3194

Merged
merged 2 commits into from
May 16, 2024
Merged

Typo fixes #3194

merged 2 commits into from
May 16, 2024

Conversation

myabc
Copy link
Contributor

@myabc myabc commented May 16, 2024

What problem is this PR intended to solve?

Fix various typos - some found via codespell and typos CLI (h/t @kianmeng with PR #3166)

Have you included adequate test coverage?

This PR does not change test coverage - existing tests should suffice.

Does this change affect the behavior of either the C or the Java implementations?

This PR does not introduce any changes in behavior.

Found manually and via

    codespell -S test,tmp,ports,coverage,googletest -L te,reencode,ocur
    typos --format brief --exclude "{char_ref.*,test,tmp,ports,coverage,googletest}"
Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this! I've made a few comments.

ext/java/nokogiri/internals/c14n/UtfHelper.java Outdated Show resolved Hide resolved
@myabc
Copy link
Contributor Author

myabc commented May 16, 2024

@flavorjones many thanks for the feedback! I've updated the PR accordingly.

@myabc myabc requested a review from flavorjones May 16, 2024 15:53
@flavorjones flavorjones merged commit 1415688 into sparklemotion:main May 16, 2024
130 checks passed
@flavorjones
Copy link
Member

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants