extract CSS selector cache into CSS::SelectorCache #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods `Parser.set_cache`, `Parser.cache_on?`, and `Parser.without_cache(&blk)` have been removed. The cache is now injected by `CSS.xpath_for` (optionally, via a `cache:` keyword argument) instead of being built into the parser. Documentation for `CSS.xpath_for` has also been updated and improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
This is part of a continuing track of work to separate out the concerns of CSS parser, CSS selector cache, and XPath expression translation into distinct components.
In this PR, I've extracted a CSS::SelectorCache class providing functionality that was previously built directly into CSS::Parser (with an awkward API that I'm responsible for writing in 2008).
Parser.set_cache,Parser.cache_on?, andParser.without_cache(&blk)have been removed.CSS.xpath_for(optionally, via acache:keyword argument) instead of being built into the parser.CSS.xpath_forhas also been updated and improved.Have you included adequate test coverage?
Mostly an internal refactor, existing test coverage is sufficient except where I removed tests of the removed methods.
Does this change affect the behavior of either the C or the Java implementations?
N/A