fix: RelaxNG.read_memory is now reliable #3259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
On both JRuby and CRuby impls, replace the native
read_memory
methodfrom XML::Schema and XML::RelaxNG with a ruby method that uses
from_document
.read_memory
was buggy on both platforms, butespecially on the JRuby impl.
This is comparable in performance on CRuby. From a benchmark taken
before this change:
IMHO the resulting code is less buggy and easier to maintain, and the
slight (if any) performance hit is worth it.
Also: improve documentation for Schema and RelaxNG classes.
Closes #2113
Closes #2115
Have you included adequate test coverage?
Does this change affect the behavior of either the C or the Java implementations?