Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SAX::ParserContext keeps a reference to the input (backport of #3395 to v1.18.x) #3396

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

flavorjones
Copy link
Member

backport #3395 to v1.18.x

to prevent it from being GCed before we parse it.

(cherry picked from commit f2a9275)
@flavorjones flavorjones added the backport Backport of a PR to the current release branch label Dec 29, 2024
@flavorjones flavorjones added this to the v1.18.x patch releases milestone Dec 29, 2024
@flavorjones flavorjones changed the title backport #3395 to v1.18.x fix: SAX::ParserContext keeps a reference to the input (backport of #3395 to v1.18.x) Dec 29, 2024
@flavorjones flavorjones changed the base branch from main to v1.18.x December 29, 2024 18:21
@flavorjones flavorjones force-pushed the flavorjones-backport-3395-1.18.x branch from e6cab02 to 1c9b8f1 Compare December 29, 2024 18:21
@flavorjones flavorjones merged commit 6344147 into v1.18.x Dec 29, 2024
144 checks passed
@flavorjones flavorjones deleted the flavorjones-backport-3395-1.18.x branch December 29, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport of a PR to the current release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant