Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): update rubyzip requirement from ~> 2.3.2 to ~> 2.4.1 #3406

Merged
merged 2 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ group :development do
gem "minitest", "5.25.4"
gem "minitest-parallel_fork", "2.0.0"
gem "ruby_memcheck", "3.0.1"
gem "rubyzip", "~> 2.3.2"
gem "rubyzip", "~> 2.4.1"
gem "simplecov", "= 0.21.2"

# rubocop
Expand Down
7 changes: 5 additions & 2 deletions test/xml/test_document_encoding.rb
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,12 @@ class TestDocumentEncoding < Nokogiri::TestCase

# no final newline on jruby. descriptive, not prescriptive.
expected_length = Nokogiri.jruby? ? xml.bytesize - 1 : xml.bytesize

assert_equal(Encoding::UTF_8, output.encoding)
assert_equal(expected_length, output.bytesize)

# Note: I dropped the assertion on the encoding of the string return from io.read
# because this behavior has changed back and forth in rubyzip versions 2.4.1 and
# 3.0.0.dev, and it's not relevant to the original bug report which was about an
# exception during writing.
end
end
end
Expand Down
Loading