Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Eth testnet not included in build #3

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Fix Eth testnet not included in build #3

merged 2 commits into from
Mar 10, 2023

Conversation

medardm
Copy link
Member

@medardm medardm commented Mar 8, 2023 •
edited
Loading

  • ETH testnet is not included in the WETH signature due to the entry having the same name with WETH in mainnet

References #1

@medardm medardm requested review from a team and swengr-janan March 8, 2023 10:10
mativanarquero
mativanarquero approved these changes Mar 9, 2023
View reviewed changes
Copy link

@mativanarquero mativanarquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aldrickb
aldrickb approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@aldrickb aldrickb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldrickb aldrickb merged commit 48c1e31 into develop Mar 10, 2023
@aldrickb aldrickb deleted the fix-eth-testnet-not-included-in-build branch March 10, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldrickb aldrickb aldrickb approved these changes

@mativanarquero mativanarquero mativanarquero approved these changes

@swengr-janan swengr-janan Awaiting requested review from swengr-janan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@medardm @mativanarquero @aldrickb