Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS support #149

Merged
merged 42 commits into from
Nov 25, 2019
Merged

tvOS support #149

merged 42 commits into from
Nov 25, 2019

Conversation

RomanPodymov
Copy link
Contributor

Hello.
Thank you for SPPermissions.
In this pull request I added support for tvOS. Some permissions are not supported for tvOS, that's why I made them available for iOS only with #if os(iOS). Tested it with CocoaPods.
Fixed SPPermissions.dialog example in README.

@ivanvorobei
Copy link
Member

Wow! Thanks for your work!

I have not encountered development for TV, I hope you can help. Could you add a new target - example for tv in project?

@RomanPodymov
Copy link
Contributor Author

Wow! Thanks for your work!

I have not encountered development for TV, I hope you can help. Could you add a new target - example for tv in project?

Done. However I see some bugs in the example for tvOS. Would you please create a branch for tvOS support?

@ivanvorobei
Copy link
Member

ivanvorobei commented Nov 25, 2019

Why need new branch? Why you can't add to this branch? I don’t find fault, I just don’t understand what you want to do.

@ivanvorobei
Copy link
Member

I think need remove for Apple TV List & Dialog controllers. Also I am try call with Native any permission - it not work (maybe need request permission only on real device?)

@RomanPodymov
Copy link
Contributor Author

Hello @ivanvorobei
OK, I will fix all tvOS-related issues in the master branch.
Permissions are also supported by tvOS simulator, I will check why Native is not displaying in the tvOS example.

@RomanPodymov
Copy link
Contributor Author

@ivanvorobei Left SPPermissionsDialogController and SPPermissionsListController for iOS only. Fixed the issue with tvOS example.

@ivanvorobei
Copy link
Member

@RomanPodymov for me in tv simulator permission not requested. Maybe I do some this wrong? Simple run and tap play for request permission.

@RomanPodymov
Copy link
Contributor Author

@ivanvorobei Fixed, check it please.

@ivanvorobei
Copy link
Member

For now all ok! Thanks)
Let me 1-3 hours for check all changes and after it I am merge and publish new version for CocoaPods.

@ivanvorobei ivanvorobei merged commit 70ca670 into sparrowcode:master Nov 25, 2019
@ivanvorobei ivanvorobei added the enhancement New feature or request label Nov 25, 2019
@ivanvorobei
Copy link
Member

I am publish new version 5.1. @RomanPodymov many thanks for your work and time!

If anybody can help, I am add new item in Cooperation section about icon for example target.

ivanvorobei pushed a commit that referenced this pull request Mar 27, 2022
ivanvorobei added a commit that referenced this pull request Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants